----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51831/ -----------------------------------------------------------
(Updated Sept. 14, 2016, 3:34 p.m.) Review request for geode, anilkumar gingade and Eric Shu. Changes ------- renamed isOffHeapPossible to mayHaveOffHeapReferences simplified implementation by just calling getOffHeap which reduced unit test changes moved isOffHeapReference to StoredObject and named it hasReferenceCount Bugs: GEODE-1886 https://issues.apache.org/jira/browse/GEODE-1886 Repository: geode Description ------- The EntryEventImpl code now checks the region first to see if it is configured off-heap. If it is not it can give up early and not bother checking if it is an instance of StoredObject. Diffs (updated) ----- geode-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryEventImpl.java bd7596f84a6a80e420c52e3a60df9e36e9a70ebb geode-core/src/main/java/com/gemstone/gemfire/internal/offheap/StoredObject.java 47ad4e2466b2604ef843dc2fb7a8cbb3225d8a8a geode-core/src/test/java/com/gemstone/gemfire/internal/cache/EntryEventImplTest.java bc8a64e8aebb497ec71290c645363a2aeb678e29 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/SearchLoadAndWriteProcessorTest.java 3e51fd9f95612bccfb96e4c68175581954af6ae4 Diff: https://reviews.apache.org/r/51831/diff/ Testing ------- precheckin, perf test Thanks, Darrel Schneider