----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53355/#review154615 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java (line 1755) <https://reviews.apache.org/r/53355/#comment224232> This changes the behavior of shutdown check. Earlier if there is concurrent create and shutdown is in progress, the "isCacheAtShutdownAll" is set while create in progress, now it will be set after the create is completed. This will impact all the methods calling "isCacheAtShutdownAll". - anilkumar gingade On Nov. 1, 2016, 11:25 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53355/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2016, 11:25 p.m.) > > > Review request for geode, anilkumar gingade and Scott Jewell. > > > Bugs: GEODE-1971 > https://issues.apache.org/jira/browse/GEODE-1971 > > > Repository: geode > > > Description > ------- > > shutdownAll now syncs on just the class instead of "this". Since it calls > close which also syncs on the class it is best to get this sync done early > and hold it for the entire shutdown. > Some other methods that were syncing on the class no longer do. They had not > reason for doing so. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > ba4f1f410cef89a276634dadecf46ac80d9c3990 > > Diff: https://reviews.apache.org/r/53355/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
