----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53355/ -----------------------------------------------------------
(Updated Nov. 4, 2016, 10:58 a.m.) Review request for geode, anilkumar gingade and Scott Jewell. Changes ------- fixed beforeShutdownAll test hook Bugs: GEODE-1971 https://issues.apache.org/jira/browse/GEODE-1971 Repository: geode Description ------- shutdownAll now syncs on just the class instead of "this". Since it calls close which also syncs on the class it is best to get this sync done early and hold it for the entire shutdown. Some other methods that were syncing on the class no longer do. They had not reason for doing so. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java ba4f1f410cef89a276634dadecf46ac80d9c3990 geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/ShutdownAllDUnitTest.java 1bb06f1ce1d93c801a51c1d8eb4f18ffeaa9f5cc Diff: https://reviews.apache.org/r/53355/diff/ Testing ------- precheckin Thanks, Darrel Schneider