Github user kjduling commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/276#discussion_r86852092
  
    --- Diff: 
geode-web-api/src/main/java/org/apache/geode/rest/internal/web/controllers/BaseControllerAdvice.java
 ---
    @@ -50,6 +52,11 @@
     
       protected static final String REST_API_VERSION = "/v1";
     
    +  public BaseControllerAdvice(final RestSecurityService securityService,
    --- End diff --
    
    BaseControllerAdvice extends AbstractBaseController.  Since the 
RestSecurityService lives in AbstractBaseController, yes.  Otherwise, we define 
separate member variables in PdxBasedCrudController, CommonCrudController, and 
QueryAccessContoller.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to