Github user kjduling commented on the issue:
https://github.com/apache/incubator-geode/pull/276
1. I am using Autowire, the annotation is on the base class's constructor.
But as for the injection via the constructor, please review
https://spring.io/blog/2015/11/29/how-not-to-hate-spring-in-2016 which
references http://olivergierke.de/2013/11/why-field-injection-is-evil/ and
http://docs.spring.io/spring-framework/docs/current/spring-framework-reference/htmlsingle/#beans-constructor-injection
Do you think it would be better to only add the RestSecurityService to the
controllers that actually need it instead of adding it to the base class? I
think that would complicate the constructors.
2 & 3. Agreed, that'll make the test cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
