[ 
http://issues.apache.org/jira/browse/GERONIMO-1035?page=comments#action_12366950
 ] 

Jeff Genender commented on GERONIMO-1035:
-----------------------------------------

Hi Anita.  Cool code...and a lot of it looks good.  But a few questions ... 
could you please explain where you shut off the web.xml parsing from Tomcat?  
It would appear that you are adding the servlets as well as Tomcat, so you 
would have double the servlet based objects created.  I did not see where the 
Digester was shut off or where you grabbed the servlet creation instead of 
Tomcat.  If you could show me where this is done, I can proceed forward in the 
testing of this code and integrating it.

> tomcat integration should wrap each servlet indiviudally
> --------------------------------------------------------
>
>          Key: GERONIMO-1035
>          URL: http://issues.apache.org/jira/browse/GERONIMO-1035
>      Project: Geronimo
>         Type: New Feature
>   Components: Tomcat
>     Versions: 1.0-M5
>  Environment: All
>     Reporter: Anita Kulshreshtha
>     Assignee: Jeff Genender
>      Fix For: 1.1
>  Attachments: geronimo-stats-1.1-SNAPSHOT.war, management.patch, stats.zip, 
> tomcat-builder.patch, tomcat-builder.patch, tomcat-builder.patch, 
> tomcat-builder.patch, tomcat.patch, tomcat.patch
>
> TomcatModuleBuilder should wrap each servlet specified in the deployment 
> descriptor individually. This is needed by JSR-77 and for gathering tomcat 
> internal statistics.   

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to