I haven't changed the test code at all. It is essentially the same as it is in the openejb-itests module. Neverthless, here it is.
http://people.apache.org/~prasad/test-ejbcontainer.zip I have simply moved it under geronimo/testsuite/ejbcontainer-testsuite/test-ejbcontainer and have ensured that it compiles fine. The reason I didn't bring it up for discussion is because it has to be located under the testsuite directory by convention. The beans can be built anywhere and the ejb-jars made available in the repo. Hence this discussion. Thanx David. Cheers Prasad On 10/27/06, David Blevins <[EMAIL PROTECTED]> wrote:
On Oct 27, 2006, at 7:34 AM, Prasad Kashyap wrote: > http://people.apache.org/~prasad/ejb-modules.zip > > You may remove the <parent> from the top level pom and adjust the > <groupId> appropriately to build this. Looks like you have the beans in there. Where is the test code? -David > Cheers > Prasad > > On 10/25/06, David Blevins <[EMAIL PROTECTED]> wrote: >> Great, I'll be looking forward to it. >> >> -David >> >> On Oct 23, 2006, at 9:36 PM, Prasad Kashyap wrote: >> >> > Thanx David. I shall try to put it in a sandbox if I can, or >> else send >> > you a a patch. >> > >> > Cheers >> > Prasad >> > >> > On 10/23/06, David Blevins <[EMAIL PROTECTED]> wrote: >> >> >> >> On Oct 23, 2006, at 2:34 PM, Prasad Kashyap wrote: >> >> >> >> > I have migrated the openejb-itests module to m2 with the >> >> intention of >> >> > using it for G's testsuite. The junit test code will have to go >> >> under >> >> > the ejbcontainer-testsuite under the testsuite framework >> >> > (geronimo/testsuite). >> >> >> >> I don't know which approach would make sense or if there is some >> >> middle ground. You have a copy of this migrated code somewhere I >> >> could look at/try out? >> >> >> >> If we did #2 it'd obviously be a copy as OpenEJB 3 runs those >> tests >> >> about 7 times during an average build and another 5 more times >> on a >> >> build with assemblies. >> >> >> >> -David >> >> >> >> > The beans and the ejub jars can go just about anywhere. So I'd >> >> like >> >> > to solicit the suggestion of openejb and geronimo folks on >> where we >> >> > should place them >> >> > >> >> > 1) Leave them where they are under openejb2/modules/openejb- >> itests. >> >> > Get help from openejb commiters to get this commited. Unlike in >> >> > previous G releases, this module would now only build the ejb >> >> jars. No >> >> > tests would actually run here. >> >> > >> >> > 2) Move/copy the ejbs to some place under testsuite and >> create the >> >> > jars there. This will keep the ejbs and the tests together. >> >> Since the >> >> > moduleId (configId) in the plans should match the m2 >> >> artifactItem id >> >> > (g:a:v:t), the moduleId in the ejb plans would then become >> >> > o.a.g.testsuite.* >> >> > >> >> > >> >> > Apart from this decision, other things that need to resolved >> >> before we >> >> > put this code in are >> >> > >> >> > http://issues.apache.org/jira/browse/OPENEJB-288 >> >> > http://www.mail-archive.com/[email protected]/ >> msg34995.html >> >> > >> >> > >> >> > Cheers >> >> > Prasad >> >> > >> >> >> >> >> > >> >> >
