I disagree. These scripts might be painful to maintain but they are very rarely updated. Switching to GShell might fix some of these maintenance problems but at the same time it introduces a number of other issues which I think I discussed before. For example, GShell will create 2 JVM processes when starting a server or app client, control-c does not work right on Windows, there are some weird input problems after starting the server in background, or abnormal JVM termination in some cases, etc.. If we managed to fix all these problems I would be ok with switching to GShell but I'm really in favor of keeping geronimo.sh, client.sh, and shutdown.sh scripts as they are.
Jarek On Fri, Nov 7, 2008 at 10:47 AM, Jason Dillon <[EMAIL PROTECTED]> wrote: > Damn these scripts, I really think we should do away with them and use > gshell. Lets *document* the non-gshell ways to java -jar bin/server/jar > ..etc... but only ship the gshell commands. > > --jason > > > On Nov 7, 2008, at 10:42 PM, Jarek Gawor wrote: > >> Donald, >> >> I'm pretty sure this change will break the script if there is no >> jpa.jar in the bin directory. >> >> Jarek >> >> On Fri, Nov 7, 2008 at 10:35 AM, <[EMAIL PROTECTED]> wrote: >>> >>> Author: dwoods >>> Date: Fri Nov 7 07:35:24 2008 >>> New Revision: 712164 >>> >>> URL: http://svn.apache.org/viewvc?rev=712164&view=rev >>> Log: >>> GERONIMO-4389 Can't start server via geronimo.sh when install path >>> contains a space. Thanks to Jun Jie Cai (Jack) for the patch. >>> >>> Modified: >>> >>> >>> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh >>> >>> Modified: >>> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh >>> URL: >>> http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh?rev=712164&r1=712163&r2=712164&view=diff >>> >>> ============================================================================== >>> --- >>> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh >>> (original) >>> +++ >>> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh >>> Fri Nov 7 07:35:24 2008 >>> @@ -314,7 +314,7 @@ >>> elif [ "$1" = "run" ]; then >>> shift >>> exec "$_RUNJAVA" $JAVA_OPTS $GERONIMO_OPTS \ >>> - $JAVA_AGENT_OPTS \ >>> + "$JAVA_AGENT_OPTS" \ >>> -Dorg.apache.geronimo.base.dir="$GERONIMO_BASE" \ >>> -Djava.endorsed.dirs="$ENDORSED_DIRS" \ >>> -Djava.ext.dirs="$EXT_DIRS" \ >>> @@ -325,7 +325,7 @@ >>> shift >>> touch "$GERONIMO_OUT" >>> $START_OS_CMD "$_RUNJAVA" $JAVA_OPTS $GERONIMO_OPTS \ >>> - $JAVA_AGENT_OPTS \ >>> + "$JAVA_AGENT_OPTS" \ >>> -Dorg.apache.geronimo.base.dir="$GERONIMO_BASE" \ >>> -Djava.endorsed.dirs="$ENDORSED_DIRS" \ >>> -Djava.ext.dirs="$EXT_DIRS" \ >>> >>> >>> > >
