Thanks Donald and Jarek! I provided another patch which hopefully fixes the problem once and for all.
-Jack 2008/11/8 Donald Woods <[EMAIL PROTECTED]> > Yes, it will, but we ship bin/jpa.jar in all the minimal and jee5 > assemblies, so if someone removes it, then they should expect something like > this to happen. > > IMO - users with spaces in the path will be a more common occurrence that > those wanting to remove the jpa.jar and worth the change... > > > -Donald > > > > Jarek Gawor wrote: > >> Donald, >> >> I'm pretty sure this change will break the script if there is no >> jpa.jar in the bin directory. >> >> Jarek >> >> On Fri, Nov 7, 2008 at 10:35 AM, <[EMAIL PROTECTED]> wrote: >> >>> Author: dwoods >>> Date: Fri Nov 7 07:35:24 2008 >>> New Revision: 712164 >>> >>> URL: http://svn.apache.org/viewvc?rev=712164&view=rev >>> Log: >>> GERONIMO-4389 Can't start server via geronimo.sh when install path >>> contains a space. Thanks to Jun Jie Cai (Jack) for the patch. >>> >>> Modified: >>> >>> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh >>> >>> Modified: >>> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh >>> URL: >>> http://svn.apache.org/viewvc/geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh?rev=712164&r1=712163&r2=712164&view=diff >>> >>> ============================================================================== >>> --- >>> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh >>> (original) >>> +++ >>> geronimo/server/trunk/assemblies/geronimo-boilerplate/src/main/underlay/contents/bin/geronimo.sh >>> Fri Nov 7 07:35:24 2008 >>> @@ -314,7 +314,7 @@ >>> elif [ "$1" = "run" ]; then >>> shift >>> exec "$_RUNJAVA" $JAVA_OPTS $GERONIMO_OPTS \ >>> - $JAVA_AGENT_OPTS \ >>> + "$JAVA_AGENT_OPTS" \ >>> -Dorg.apache.geronimo.base.dir="$GERONIMO_BASE" \ >>> -Djava.endorsed.dirs="$ENDORSED_DIRS" \ >>> -Djava.ext.dirs="$EXT_DIRS" \ >>> @@ -325,7 +325,7 @@ >>> shift >>> touch "$GERONIMO_OUT" >>> $START_OS_CMD "$_RUNJAVA" $JAVA_OPTS $GERONIMO_OPTS \ >>> - $JAVA_AGENT_OPTS \ >>> + "$JAVA_AGENT_OPTS" \ >>> -Dorg.apache.geronimo.base.dir="$GERONIMO_BASE" \ >>> -Djava.endorsed.dirs="$ENDORSED_DIRS" \ >>> -Djava.ext.dirs="$EXT_DIRS" \ >>> >>> >>> >>> >>
