rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2
changes
URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280868170
##########
File path:
geronimo-opentracing-common/src/main/java/org/apache/geronimo/microprofile/opentracing/common/microprofile/zipkin/ZipkinConverter.java
##########
@@ -50,6 +50,7 @@
private IdGenerator idGenerator;
private String serviceName;
+ private boolean useV2 = false;
Review comment:
I think it can be worth to have 2 converters and configure it in the
extension as other observers. Will ensure setup is not resolved at runtime.
Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
