rmannibucau commented on a change in pull request #1: GERONIMO-6727 Zipkin v2
changes
URL: https://github.com/apache/geronimo-opentracing/pull/1#discussion_r280866557
##########
File path:
geronimo-opentracing-common/src/main/java/org/apache/geronimo/microprofile/opentracing/common/microprofile/zipkin/ZipkinSpan.java
##########
@@ -30,7 +30,6 @@
private ZipkinEndpoint localEndpoint;
private ZipkinEndpoint remoteEndpoint;
private List<ZipkinAnnotation> annotations;
- private List<ZipkinBinaryAnnotation> binaryAnnotations;
Review comment:
Is it ok to break this - it is unclear if an user api (due to the event) or
not.
If so let's document it in geronimo-microprofile site.
Wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
