rmannibucau commented on a change in pull request #17: Always use reusable
object component
URL: https://github.com/apache/geronimo-openapi/pull/17#discussion_r320046707
##########
File path:
geronimo-openapi-impl/src/main/java/org/apache/geronimo/microprofile/openapi/impl/processor/SchemaProcessor.java
##########
@@ -145,45 +146,22 @@ public void fillSchema(
fillSchema(components, Object.class, items, null);
schema.items(items);
} else {
- ofNullable(from.getAnnotation(Schema.class)).ifPresent(
- s -> sets(components, Schema.class.cast(s),
schema, null));
+ Optional<Annotation> annotation =
ofNullable(from.getAnnotation(Schema.class));
Review comment:
Can be typed Optional[Schema] to avoid the casts some lines later or just
keep the getAnnotation result on previous line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
