rmannibucau commented on a change in pull request #17: Always use reusable
object component
URL: https://github.com/apache/geronimo-openapi/pull/17#discussion_r320046774
##########
File path:
geronimo-openapi-impl/src/main/java/org/apache/geronimo/microprofile/openapi/impl/processor/SchemaProcessor.java
##########
@@ -99,7 +100,7 @@ public void fillSchema(
final
Supplier<org.eclipse.microprofile.openapi.models.Components>components,
final Type rawModel,
final org.eclipse.microprofile.openapi.models.media.Schema schema,
- final String providedRef) {
Review comment:
Maybe keep it final to avoid to change inputs within the method (just the
overall pattern so probably saner to keep it unified IMHO)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
