rmannibucau commented on a change in pull request #4: GERONIMO-6757 if we can
avoid CDI.current by injecting, please do! otherwise go ahead.
URL: https://github.com/apache/geronimo-jwt-auth/pull/4#discussion_r355215291
##########
File path:
src/main/java/org/apache/geronimo/microprofile/impl/jwtauth/servlet/GeronimoJwtAuthFilter.java
##########
@@ -42,17 +43,27 @@
private String headerName;
private String cookieName;
private String prefix;
+ @Inject
private JwtParser service;
+ @Inject
private GeronimoJwtAuthExtension extension;
private Collection<String> publicUrls;
+ @Inject
+ private GeronimoJwtAuthConfig config;
@Override
public void init(final FilterConfig filterConfig) {
final CDI<Object> current = CDI.current();
Review comment:
Should be init to null and lazily initialized no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
