rmannibucau commented on a change in pull request #4: GERONIMO-6757 if we can 
avoid CDI.current by injecting, please do! otherwise go ahead.
URL: https://github.com/apache/geronimo-jwt-auth/pull/4#discussion_r355334212
 
 

 ##########
 File path: 
src/main/java/org/apache/geronimo/microprofile/impl/jwtauth/jwt/KidMapper.java
 ##########
 @@ -82,7 +82,7 @@ private void init() {
         defaultKey = config.read("public-key.default", 
config.read(Names.VERIFIER_PUBLIC_KEY, null));
     }
 
-    String loadKey(final String property) {
+    public String loadKey(final String property) {
 
 Review comment:
   this is because of aries-owb proxy definition, so the proxy is NOT a 
passthrough but since the delegated method is in another classloader it does 
not call it.
   Not sure we can do something better without rewiring the proxies so ok to 
make it public (just to clarify the root cause)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to