rotty3000 commented on a change in pull request #4: GERONIMO-6757 if we can 
avoid CDI.current by injecting, please do! otherwise go ahead.
URL: https://github.com/apache/geronimo-jwt-auth/pull/4#discussion_r355228344
 
 

 ##########
 File path: 
src/main/java/org/apache/geronimo/microprofile/impl/jwtauth/cdi/GeronimoJwtAuthExtension.java
 ##########
 @@ -85,9 +85,8 @@ void setClaimMethodsBinding(@Observes final 
BeforeBeanDiscovery beforeBeanDiscov
 
     void captureInjections(@Observes final ProcessInjectionPoint<?, ?> 
processInjectionPoint) {
         final InjectionPoint injectionPoint = 
processInjectionPoint.getInjectionPoint();
-        ofNullable(injectionPoint.getAnnotated().getAnnotation(Claim.class))
-                .flatMap(claim -> createInjection(claim, 
injectionPoint.getType()))
-                .ifPresent(injectionPoints::add);
+        
ofNullable(injectionPoint.getAnnotated().getAnnotation(Claim.class)).ifPresent(
 
 Review comment:
   No this is a legit NPE issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to