Proxy supports primitives so default is not always null compared to injections, no? Once this point materialized by a test - and maybe imports reorganized to minimize the diff? - i guess we are good to merge.
Le sam. 25 janv. 2020 à 18:37, Daniel Cunha <[email protected]> a écrit : > I updated the PR. Hope it is in a good shape now! > > Thank you. > > Em sáb., 25 de jan. de 2020 às 13:08, Romain Manni-Bucau < > [email protected]> escreveu: > >> Except a small import issue (*) i guess it just needs the proxy handling >> (in our invocation handler)of default value and some test(s) then it looks >> pretty good to me. >> >> Le sam. 25 janv. 2020 à 17:01, Daniel Cunha <[email protected]> a >> écrit : >> >>> Hi Folks, >>> >>> https://github.com/apache/geronimo-config/pull/6 >>> >>> That is the PR with changes to cover MicroProfile 1.4-RC on Geronimo >>> Config. >>> I really appreciate if someone could put the eyes on it. >>> >>> Thank you. >>> >>> -- >>> Daniel "soro" Cunha >>> https://twitter.com/dvlc_ >>> >> > > -- > Daniel "soro" Cunha > https://twitter.com/dvlc_ >
