FYI I just fixed master code - test was using the proxy fields instead of injected values. Feel free to review and enhance if needed.
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le dim. 26 janv. 2020 à 08:28, Romain Manni-Bucau <[email protected]> a écrit : > Merged, thks a lot Daniel > > Le dim. 26 janv. 2020 à 01:25, Daniel Cunha <[email protected]> a > écrit : > >> I believe now it's in a good shape. >> >> >> Thank you, Romain. >> >> >> -- >> Daniel "soro" Cunha >> https://twitter.com/dvlc_ >> >> On Sat, Jan 25, 2020, 17:55 Romain Manni-Bucau <[email protected]> >> wrote: >> >>> You dont need to parse constants : >>> >>> Long.parseLong("0") -> 0L ;) >>> >>> >>> Otherwise looks perfect for me >>> If nobody shouts, i will merge it tmr or on monday >>> >>> Le sam. 25 janv. 2020 à 20:10, Daniel Cunha <[email protected]> a >>> écrit : >>> >>>> Changes sent! >>>> >>>> Thank you for your review Romain. >>>> >>>> Em sáb., 25 de jan. de 2020 às 15:05, Romain Manni-Bucau < >>>> [email protected]> escreveu: >>>> >>>>> Proxy supports primitives so default is not always null compared to >>>>> injections, no? Once this point materialized by a test - and maybe imports >>>>> reorganized to minimize the diff? - i guess we are good to merge. >>>>> >>>>> Le sam. 25 janv. 2020 à 18:37, Daniel Cunha <[email protected]> a >>>>> écrit : >>>>> >>>>>> I updated the PR. Hope it is in a good shape now! >>>>>> >>>>>> Thank you. >>>>>> >>>>>> Em sáb., 25 de jan. de 2020 às 13:08, Romain Manni-Bucau < >>>>>> [email protected]> escreveu: >>>>>> >>>>>>> Except a small import issue (*) i guess it just needs the proxy >>>>>>> handling (in our invocation handler)of default value and some test(s) >>>>>>> then >>>>>>> it looks pretty good to me. >>>>>>> >>>>>>> Le sam. 25 janv. 2020 à 17:01, Daniel Cunha <[email protected]> >>>>>>> a écrit : >>>>>>> >>>>>>>> Hi Folks, >>>>>>>> >>>>>>>> https://github.com/apache/geronimo-config/pull/6 >>>>>>>> >>>>>>>> That is the PR with changes to cover MicroProfile 1.4-RC on >>>>>>>> Geronimo Config. >>>>>>>> I really appreciate if someone could put the eyes on it. >>>>>>>> >>>>>>>> Thank you. >>>>>>>> >>>>>>>> -- >>>>>>>> Daniel "soro" Cunha >>>>>>>> https://twitter.com/dvlc_ >>>>>>>> >>>>>>> >>>>>> >>>>>> -- >>>>>> Daniel "soro" Cunha >>>>>> https://twitter.com/dvlc_ >>>>>> >>>>> >>>> >>>> -- >>>> Daniel "soro" Cunha >>>> https://twitter.com/dvlc_ >>>> >>>
