[ https://issues.apache.org/jira/browse/GIRAPH-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430422#comment-13430422 ]
Alessandro Presta commented on GIRAPH-287: ------------------------------------------ Just to be clear, this allows to pause the computation when the number of message requests we have sent (and that appear not to have been processed yet) is above a threshold (Maja, correct me if I'm wrong). Patch looks good, and it's switched off by default, so this should be safe to include. One small nit: I think you want to change the log message to "waitSomeRequests" too. I'll wait to see if anyone has comments in the next couple of days. > Add option to limit the number of open requests > ----------------------------------------------- > > Key: GIRAPH-287 > URL: https://issues.apache.org/jira/browse/GIRAPH-287 > Project: Giraph > Issue Type: Improvement > Reporter: Maja Kabiljo > Assignee: Maja Kabiljo > Attachments: GIRAPH-287.patch > > > As I mentioned in the discussion on the mailing list, GIRAPH-45 patch itself > wasn't enough to run jobs with any amount of messages data. The thing which > can still happen is that we have too many send messages requests to which we > didn't get replies yet, so these requests use all our memory. Adding limit on > the number of open requests will fix that last case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira