[ 
https://issues.apache.org/jira/browse/GIRAPH-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430588#comment-13430588
 ] 

Jakob Homan commented on GIRAPH-287:
------------------------------------

OK. My only comment would be to move the definition of the constants to 
NettyClient.  It's best not to load GiraphJob up with definitions for other 
components.  Current patch passes mvn verify.  +1 once the constants are moved.
                
> Add option to limit the number of open requests
> -----------------------------------------------
>
>                 Key: GIRAPH-287
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-287
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-287.patch
>
>
> As I mentioned in the discussion on the mailing list, GIRAPH-45 patch itself 
> wasn't enough to run jobs with any amount of messages data. The thing which 
> can still happen is that we have too many send messages requests to which we 
> didn't get replies yet, so these requests use all our memory. Adding limit on 
> the number of open requests will fix that last case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to