[
https://issues.apache.org/jira/browse/GIRAPH-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899234#comment-13899234
]
Pavan Kumar commented on GIRAPH-840:
------------------------------------
Eugune,
My diff was based off of http://pastebin.com/uxtK6TPz
There is a merge conflict in pom.xml
So please apply against the above version then rebase. (or I just attached a
non-conflicting patch in jira for convenience)
Otherwise I thought the review will get messed up also showing changes from
commits after the base commit (which I did not make, so confusing the
reviewers; sorry first time here)
> Upgrade to netty 4
> ------------------
>
> Key: GIRAPH-840
> URL: https://issues.apache.org/jira/browse/GIRAPH-840
> Project: Giraph
> Issue Type: Improvement
> Reporter: Pavan Kumar
> Assignee: Pavan Kumar
> Fix For: 1.1.0
>
>
> Off late netty 4 has earned so much praise in the community. For example,
> https://blog.twitter.com/2013/netty-4-at-twitter-reduced-gc-overhead
> A switch to netty 4 enables a significant reduction in gc pressure and also
> huge performance gains. I started working on this last Sunday and have a
> patch that shows performance gains on the order of 15-25% (total execution
> time) for some applications at Facebook. However, I only tested it with
> hadoop_facebook. So there might be issues with SASL path.
> I will release the patch today and want to open up a discussion if anyone is
> using the secure feature anymore. If not we can just deprecate it.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
