[ 
https://issues.apache.org/jira/browse/GIRAPH-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13900564#comment-13900564
 ] 

Eugene Koontz commented on GIRAPH-840:
--------------------------------------

Hi Pavan,

Currently there are no SASL unit tests - I added GIRAPH-852 for these. I have 
not had a chance to test your patch with an existing SASL setup. However the 
changes you made related to SASL look fine to me.

> Upgrade to netty 4
> ------------------
>
>                 Key: GIRAPH-840
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-840
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Pavan Kumar
>            Assignee: Pavan Kumar
>             Fix For: 1.1.0
>
>         Attachments: GIRAPH-840.patch, GIRAPH-840.patch
>
>
> Off late netty 4 has earned so much praise in the community. For example, 
> https://blog.twitter.com/2013/netty-4-at-twitter-reduced-gc-overhead
> A switch to netty 4 enables a significant reduction in gc pressure and also 
> huge performance gains. I started working on this last Sunday and have a 
> patch that shows performance gains on the order of 15-25% (total execution 
> time) for some applications at Facebook. However, I only tested it with 
> hadoop_facebook. So there might be issues with SASL path. 
> I will release the patch today and want to open up a discussion if anyone is 
> using the secure feature anymore. If not we can just deprecate it.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to