[
https://issues.apache.org/jira/browse/GIRAPH-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998668#comment-15998668
]
ASF GitHub Bot commented on GIRAPH-1146:
----------------------------------------
Github user majakabiljo commented on a diff in the pull request:
https://github.com/apache/giraph/pull/36#discussion_r115053732
--- Diff:
giraph-block-app/src/main/java/org/apache/giraph/block_app/framework/BlockUtils.java
---
@@ -147,6 +148,11 @@ public static void
initAndCheckConfig(GiraphConfiguration conf) {
checkBlockTypes(
executionBlock, blockFactory.createExecutionStage(immConf),
immConf);
+ PieceCount pieceCount = executionBlock.getPieceCount();
+ if (pieceCount.isKnown()) {
+ GiraphConstants.SUPERSTEP_COUNT.set(conf, pieceCount.getCount());
--- End diff --
There will be X+1 supersteps, but they are going to be supersteps 0..X.
Actually I can make +1 here and then -1 in the logging part to keep it clear.
> Keep track of number of supersteps when possible
> ------------------------------------------------
>
> Key: GIRAPH-1146
> URL: https://issues.apache.org/jira/browse/GIRAPH-1146
> Project: Giraph
> Issue Type: New Feature
> Reporter: Maja Kabiljo
> Assignee: Maja Kabiljo
> Priority: Minor
>
> In many cases we know how many supersteps are there going to be. We can keep
> track of it and log it with progress.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
