[ 
https://issues.apache.org/jira/browse/GIRAPH-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003732#comment-16003732
 ] 

ASF GitHub Bot commented on GIRAPH-1146:
----------------------------------------

Github user ikabiljo commented on a diff in the pull request:

    https://github.com/apache/giraph/pull/36#discussion_r115624215
  
    --- Diff: 
giraph-block-app/src/main/java/org/apache/giraph/block_app/framework/piece/delegate/DelegatePiece.java
 ---
    @@ -249,6 +250,11 @@ public void 
forAllPossiblePieces(Consumer<AbstractPiece> consumer) {
         }
       }
     
    +  @Override
    --- End diff --
    
    you don't need to extend, default is 1 for any piece :)


> Keep track of number of supersteps when possible
> ------------------------------------------------
>
>                 Key: GIRAPH-1146
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1146
>             Project: Giraph
>          Issue Type: New Feature
>            Reporter: Maja Kabiljo
>            Assignee: Maja Kabiljo
>            Priority: Minor
>
> In many cases we know how many supersteps are there going to be. We can keep 
> track of it and log it with progress.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to