[
https://issues.apache.org/jira/browse/GIRAPH-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420960#comment-16420960
]
ASF GitHub Bot commented on GIRAPH-1181:
----------------------------------------
Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/65#discussion_r178388788
--- Diff:
giraph-core/src/main/java/org/apache/giraph/utils/UnsafeReads.java ---
@@ -18,27 +18,24 @@
package org.apache.giraph.utils;
+import com.esotericsoftware.kryo.io.Input;
+
import java.io.IOException;
import java.io.UTFDataFormatException;
/**
* Byte array input stream that uses Unsafe methods to deserialize
* much faster
*/
-public abstract class UnsafeReads implements ExtendedDataInput {
-
- /** Buffer length */
- protected int bufLength;
- /** Position in the buffer */
- protected long pos = 0;
+public abstract class UnsafeReads extends Input implements
ExtendedDataInput {
--- End diff --
Can we add some unit tests for UnsafeReads/UnsafeByteArrayInputStream just
like with UnsafeByteArrayOutputStream?
> Changes to ExtendedByteArrayDataOutput
> --------------------------------------
>
> Key: GIRAPH-1181
> URL: https://issues.apache.org/jira/browse/GIRAPH-1181
> Project: Giraph
> Issue Type: Improvement
> Reporter: Yuksel Akinci
> Priority: Major
>
> Adding a new stream type which extends from
> com.esotericsoftware.kryo.io.Input/Output, so that it can be used with kryo
> serializer. It improves the performance of kryo by faster read/writes (unsafe
> IO), and also eliminates the need for interim buffers to convert from
> DataInput and DataOutput.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
