[ https://issues.apache.org/jira/browse/GIRAPH-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422852#comment-16422852 ]
ASF GitHub Bot commented on GIRAPH-1181: ---------------------------------------- Github user yukselakinci commented on a diff in the pull request: https://github.com/apache/giraph/pull/65#discussion_r178601775 --- Diff: giraph-core/src/main/java/org/apache/giraph/utils/UnsafeByteArrayOutputStream.java --- @@ -36,7 +37,7 @@ * Byte array output stream that uses Unsafe methods to serialize/deserialize * much faster */ -public class UnsafeByteArrayOutputStream extends OutputStream +public class UnsafeByteArrayOutputStream extends Output --- End diff -- I have done some benchmarking with the additional changes that depend on this pull request ( I will send a separate PR for that). For this PR, my testing focused on correctness and making sure that there is no performance regression. > Changes to ExtendedByteArrayDataOutput > -------------------------------------- > > Key: GIRAPH-1181 > URL: https://issues.apache.org/jira/browse/GIRAPH-1181 > Project: Giraph > Issue Type: Improvement > Reporter: Yuksel Akinci > Priority: Major > > Adding a new stream type which extends from > com.esotericsoftware.kryo.io.Input/Output, so that it can be used with kryo > serializer. It improves the performance of kryo by faster read/writes (unsafe > IO), and also eliminates the need for interim buffers to convert from > DataInput and DataOutput. -- This message was sent by Atlassian JIRA (v7.6.3#76005)