[jira] [Commented] (GIRAPH-1205) Separate Giraph counters for different causes of network request resends

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/GIRAPH-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650557#comment-16650557
 ] 

ASF GitHub Bot commented on GIRAPH-1205:
----------------------------------------

Github user atanu1991 commented on the issue:

    https://github.com/apache/giraph/pull/88
  
    Test plan:
    Tested internally by running hello page rank 
    drop=true ./hellopagerank.sh -DhelloPageRank.iterations=5000 
-Dgiraph.maxRequestMilliseconds=1 -Dgiraph.waitingRequestMsecs=1
    
    The new counters are seen
    ![screen shot 2018-10-15 at 10 38 57 
am](https://user-images.githubusercontent.com/1309583/46969415-d432a600-d06a-11e8-9623-19e7f8b76b24.png)



> Separate Giraph counters for different causes of network request resends
> ------------------------------------------------------------------------
>
>                 Key: GIRAPH-1205
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-1205
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Atanu Ghosh
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In 
> [https://issues.apache.org/jira/browse/GIRAPH-1200|https://l.facebook.com/l.php?u=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGIRAPH-1200&h=AT0QcRraYr63snHpZlSQ0PxkTc7wY3aucSzdquAnmVSBxVA5AsPAK5m3YEzR7CndOtcjRhHC0vJc8z1ZFmCnJCnH5vyyboH5_zu_pWfC_BxBji3f6JwogLv7xX4tIXQ166Tzise5MUcFYPkP6Jsj7VZV]
>  we added counters for network requests resends, but "network resends for 
> timeout" actually cover various reasons for why request can get resent. We 
> suspect that resending requests after maxRequestMilliseconds timeout is what 
> is always fatal, so separating this counter from the other causes will help 
> us verify that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)