[
https://issues.apache.org/jira/browse/GIRAPH-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653833#comment-16653833
]
ASF GitHub Bot commented on GIRAPH-1205:
----------------------------------------
Github user majakabiljo commented on a diff in the pull request:
https://github.com/apache/giraph/pull/88#discussion_r226012078
--- Diff:
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
@@ -141,6 +141,9 @@
/** How many network requests were resent because channel failed */
public static final String
NETWORK_REQUESTS_RESENT_FOR_CHANNEL_FAILURE_NAME =
"Network requests resent for channel failure";
+ /** How many network requests were resent because connection failed */
+ public static final String
NETWORK_REQUESTS_RESENT_FOR_CONNECTION_FAILURE =
--- End diff --
Nit: NETWORK_REQUESTS_RESENT_FOR_CONNECTION_FAILURE_NAME
> Separate Giraph counters for different causes of network request resends
> ------------------------------------------------------------------------
>
> Key: GIRAPH-1205
> URL: https://issues.apache.org/jira/browse/GIRAPH-1205
> Project: Giraph
> Issue Type: Improvement
> Reporter: Atanu Ghosh
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> In
> [https://issues.apache.org/jira/browse/GIRAPH-1200|https://l.facebook.com/l.php?u=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FGIRAPH-1200&h=AT0QcRraYr63snHpZlSQ0PxkTc7wY3aucSzdquAnmVSBxVA5AsPAK5m3YEzR7CndOtcjRhHC0vJc8z1ZFmCnJCnH5vyyboH5_zu_pWfC_BxBji3f6JwogLv7xX4tIXQ166Tzise5MUcFYPkP6Jsj7VZV]
> we added counters for network requests resends, but "network resends for
> timeout" actually cover various reasons for why request can get resent. We
> suspect that resending requests after maxRequestMilliseconds timeout is what
> is always fatal, so separating this counter from the other causes will help
> us verify that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
