GitHub user majakabiljo opened a pull request:
https://github.com/apache/giraph/pull/93
GIRAPH-1211: Make retrying to send network requests after timeout optional
Summary: Using counters added in GIRAPH-1205 we were able to confirm that
resending network requests after timeout almost never succeeds, so add an
option to fail early instead of keep trying to resend these network requests
indefinitely.
Test Plan: Made response not being sent for a specific request id, verified
that with keeping default value for this new option we kept trying to resend
the request, and when making it false the job failed when request timeout was
noticed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/majakabiljo/giraph giraph-1211
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/giraph/pull/93.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #93
----
commit 1ce1a8e50565cf7adb4d5ebce872620949f3f906
Author: Maja Kabiljo <majakabiljo@...>
Date: 2018-11-07T04:50:28Z
GIRAPH-1211: Make retrying to send network requests after timeout optional
Summary: Using counters added in GIRAPH-1205 we were able to confirm that
resending network requests after timeout almost never succeeds, so add an
option to fail early instead of keep trying to resend these network requests
indefinitely.
Test Plan: Made response not being sent for a specific request id, verified
that with keeping default value for this new option we kept trying to resend
the request, and when making it false the job failed when request timeout was
noticed.
----
---
