Github user dlogothetis commented on a diff in the pull request:
https://github.com/apache/giraph/pull/93#discussion_r231388167
--- Diff:
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java ---
@@ -1006,18 +1013,21 @@ public boolean apply(RequestInfo requestInfo) {
return writeFuture != null && (!writeFuture.channel().isActive() ||
(writeFuture.isDone() && !writeFuture.isSuccess()));
}
- }, networkRequestsResentForConnectionFailure);
+ }, networkRequestsResentForConnectionFailure, true);
}
/**
* Resend requests which satisfy predicate
* @param shouldResendRequestPredicate Predicate to use to check whether
* request should be resent
* @param counter Counter to increment for every resent network request
+ * @param resendProblematicRequest Whether to resend problematic request
or
+ * fail th job if such request is found
--- End diff --
```suggestion
* fail the job if such request is found
```
---
