aanchal204 commented on a change in pull request #118: Fix issues with channel
re-connection
URL: https://github.com/apache/giraph/pull/118#discussion_r358373326
##########
File path:
giraph-core/src/main/java/org/apache/giraph/comm/netty/NettyClient.java
##########
@@ -764,25 +764,27 @@ public void operationComplete(ChannelFuture cf) {
private Channel getNextChannel(InetSocketAddress remoteServer) {
Channel channel = addressChannelMap.get(remoteServer).nextChannel();
if (channel == null) {
- throw new IllegalStateException(
- "getNextChannel: No channel exists for " + remoteServer);
+ LOG.warn("getNextChannel: No channel exists for " + remoteServer);
}
- // Return this channel if it is connected
- if (channel.isActive()) {
- return channel;
- }
+ if (channel != null) {
Review comment:
nit: can simply use else {}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
