aanchal204 commented on a change in pull request #118: Fix issues with channel
re-connection
URL: https://github.com/apache/giraph/pull/118#discussion_r358372737
##########
File path:
giraph-core/src/main/java/org/apache/giraph/comm/netty/ChannelRotater.java
##########
@@ -73,9 +76,9 @@ public synchronized void addChannel(Channel channel) {
*/
public synchronized Channel nextChannel() {
if (channelList.isEmpty()) {
- throw new IllegalArgumentException(
- "nextChannel: No channels exist for hostname " +
- address.getHostName());
+ LOG.warn("nextChannel: No channels exist for hostname " +
+ address.getHostName());
+ return null;
Review comment:
Will the job never fail in this case, then? What happens if the channel
keeps getting dropped for some reason?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
