sv2000 commented on a change in pull request #3124:
URL: https://github.com/apache/incubator-gobblin/pull/3124#discussion_r504819940
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResource.java
##########
@@ -52,10 +55,19 @@
public class FlowExecutionResource extends
ComplexKeyResourceTemplate<FlowStatusId, EmptyRecord, FlowExecution> {
private static final Logger LOG =
LoggerFactory.getLogger(FlowExecutionResource.class);
public static final String FLOW_STATUS_GENERATOR_INJECT_NAME =
"FlowStatusGenerator";
+ public static final String EVENTBUS_INJECT_NAME = "EventBus";
+ public static final String HELIX_MANAGER_INJECT_NAME = "HelixManager";
+ public static final String FORCE_LEADER_INJECT_NAME = "ForceLeader";
public static final String MESSAGE_SEPARATOR = ", ";
@Inject @javax.inject.Inject
@javax.inject.Named(FLOW_STATUS_GENERATOR_INJECT_NAME)
FlowStatusGenerator _flowStatusGenerator;
+ @Inject @javax.inject.Inject @javax.inject.Named(EVENTBUS_INJECT_NAME)
+ EventBus eventBus;
+ @Inject @javax.inject.Inject @javax.inject.Named(HELIX_MANAGER_INJECT_NAME)
Review comment:
It seems like we don't really need a HelixManager instance here and the
dependency on helix module can be removed. Can HelixLeaderUtils create a
singleton HelixManager instance that it uses to check the leader status?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
