jack-moseley commented on a change in pull request #3124:
URL: https://github.com/apache/incubator-gobblin/pull/3124#discussion_r505936225
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResource.java
##########
@@ -52,10 +55,19 @@
public class FlowExecutionResource extends
ComplexKeyResourceTemplate<FlowStatusId, EmptyRecord, FlowExecution> {
Review comment:
Added a change to:
- Add `FlowExecutionResourceHandler`
- Add `GobblinServiceFlowExecutionResourceHandler` which just calls the
underlying one, except for delete where it does the leadership check
- Merge the `HelixLeaderUtils` methods into `HelixUtils` in gobblin-service
and remove the extra helix dependencies added earlier
- Pass eventbus/helixmanager/flowstatusgenerator directly to
flowExecutionResourceHandler instead of injecting them, and also switch to
building flowstatusgenerator here instead of internally (since there is no
reason for it to be internal)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
