[
https://issues.apache.org/jira/browse/GOBBLIN-1337?focusedWorklogId=524194&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524194
]
ASF GitHub Bot logged work on GOBBLIN-1337:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/20 00:53
Start Date: 15/Dec/20 00:53
Worklog Time Spent: 10m
Work Description: abhizen commented on a change in pull request #3174:
URL: https://github.com/apache/incubator-gobblin/pull/3174#discussion_r542961413
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaTopicGroupingWorkUnitPacker.java
##########
@@ -251,7 +251,7 @@ private void addStatsToWorkUnits(Map<String,
List<WorkUnit>> workUnitsByTopic) t
List<WorkUnit> workUnits = entry.getValue();
for (WorkUnit workUnit : workUnits) {
int partitionId =
Integer.parseInt(workUnit.getProp(KafkaSource.PARTITION_ID));
- String topicPartition = new
KafkaPartition.Builder().withTopicName(topic).withId(partitionId).toString();
+ String topicPartition = new
KafkaPartition.Builder().withTopicName(topic).withId(partitionId).build().toString();
Review comment:
are there any unit tests for this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524194)
Time Spent: 40m (was: 0.5h)
> Fix string representation of KafkaPartition in
> KafkaTopicGroupingWorkUnitPacker
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-1337
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1337
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-kafka
> Affects Versions: 0.16.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Current implementation does not call build() on the KafkaPartition.Builder
> before calling toString().
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
