[
https://issues.apache.org/jira/browse/GOBBLIN-1337?focusedWorklogId=524306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524306
]
ASF GitHub Bot logged work on GOBBLIN-1337:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/20 08:09
Start Date: 15/Dec/20 08:09
Worklog Time Spent: 10m
Work Description: codecov-io edited a comment on pull request #3174:
URL:
https://github.com/apache/incubator-gobblin/pull/3174#issuecomment-745030606
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3174?src=pr&el=h1)
Report
> Merging
[#3174](https://codecov.io/gh/apache/incubator-gobblin/pull/3174?src=pr&el=desc)
(d3e8725) into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/720eac240a763e81201f147acd27c52d93159516?el=desc)
(720eac2) will **decrease** coverage by `37.07%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3174?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3174 +/- ##
============================================
- Coverage 46.18% 9.10% -37.08%
+ Complexity 9754 1724 -8030
============================================
Files 2014 2014
Lines 77095 77095
Branches 8559 8559
============================================
- Hits 35606 7022 -28584
- Misses 38181 69390 +31209
+ Partials 3308 683 -2625
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3174?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...kunit/packer/KafkaTopicGroupingWorkUnitPacker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS93b3JrdW5pdC9wYWNrZXIvS2Fma2FUb3BpY0dyb3VwaW5nV29ya1VuaXRQYWNrZXIuamF2YQ==)
| `0.00% <0.00%> (-39.50%)` | `0.00 <0.00> (-11.00)` | |
|
[...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
|
[...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
|
[...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...org/apache/gobblin/ack/BasicAckableForTesting.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYWNrL0Jhc2ljQWNrYWJsZUZvclRlc3RpbmcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
|
[...n/java/org/apache/gobblin/salesforce/SfConfig.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvU2ZDb25maWcuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[.../org/apache/gobblin/yarn/HelixMessageSubTypes.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vSGVsaXhNZXNzYWdlU3ViVHlwZXMuamF2YQ==)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
|
[...va/org/apache/gobblin/cluster/SingleHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlSGVsaXhUYXNrLmphdmE=)
| `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [1060
more](https://codecov.io/gh/apache/incubator-gobblin/pull/3174/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3174?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3174?src=pr&el=footer).
Last update
[720eac2...d3e8725](https://codecov.io/gh/apache/incubator-gobblin/pull/3174?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524306)
Time Spent: 1.5h (was: 1h 20m)
> Fix string representation of KafkaPartition in
> KafkaTopicGroupingWorkUnitPacker
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-1337
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1337
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-kafka
> Affects Versions: 0.16.0
> Reporter: Sudarshan Vasudevan
> Assignee: Shirshanka Das
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Current implementation does not call build() on the KafkaPartition.Builder
> before calling toString().
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
