[
https://issues.apache.org/jira/browse/GOBBLIN-1380?focusedWorklogId=548942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-548942
]
ASF GitHub Bot logged work on GOBBLIN-1380:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/21 01:26
Start Date: 06/Feb/21 01:26
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3220:
URL: https://github.com/apache/incubator-gobblin/pull/3220#discussion_r571331140
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -194,6 +198,7 @@ public DagManager(Config config, boolean
instrumentationEnabled) {
this.resumeQueue = initializeDagQueue(this.numThreads);
this.scheduledExecutorPool = Executors.newScheduledThreadPool(numThreads);
this.pollingInterval = ConfigUtils.getInt(config,
JOB_STATUS_POLLING_INTERVAL_KEY, DEFAULT_JOB_STATUS_POLLING_INTERVAL);
+ this.retentionInterval = ConfigUtils.getInt(config,
FAILED_DAG_POLLING_INTERVAL, DEFAULT_FAILED_DAG_POLLING_INTERVAL);
Review comment:
`retentionInterval` does not look like the best choice given it is
actually a polling interval
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -172,12 +178,15 @@ public String toString() {
@Getter
private final Integer numThreads;
private final Integer pollingInterval;
+ private final Integer retentionInterval;
@Getter
private final JobStatusRetriever jobStatusRetriever;
private final Config config;
private final Optional<EventSubmitter> eventSubmitter;
private final int defaultQuota;
private final Map<String, Integer> perUserQuota;
+ private final long failedDagRetentionTime;
+ private final Map<String, Dag<JobExecutionPlan>> failedDags = new
ConcurrentHashMap<>();
Review comment:
Why did we start creating this map here instead of inside
DagManagerThread?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 548942)
Time Spent: 2h (was: 1h 50m)
> Add retention to failed dag state store
> ---------------------------------------
>
> Key: GOBBLIN-1380
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1380
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
