[
https://issues.apache.org/jira/browse/GOBBLIN-1380?focusedWorklogId=548953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-548953
]
ASF GitHub Bot logged work on GOBBLIN-1380:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/21 03:09
Start Date: 06/Feb/21 03:09
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3220:
URL: https://github.com/apache/incubator-gobblin/pull/3220#discussion_r571347627
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -172,12 +178,15 @@ public String toString() {
@Getter
private final Integer numThreads;
private final Integer pollingInterval;
+ private final Integer retentionInterval;
@Getter
private final JobStatusRetriever jobStatusRetriever;
private final Config config;
private final Optional<EventSubmitter> eventSubmitter;
private final int defaultQuota;
private final Map<String, Integer> perUserQuota;
+ private final long failedDagRetentionTime;
+ private final Map<String, Dag<JobExecutionPlan>> failedDags = new
ConcurrentHashMap<>();
Review comment:
The retention thread needs to delete from the same map as well,
otherwise the DagManagerThread will think there is a failed dag but not find it
in the failed dag state store. The failedDags map is basically a local version
of the failed dag state store to avoid querying it often.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 548953)
Time Spent: 2h 10m (was: 2h)
> Add retention to failed dag state store
> ---------------------------------------
>
> Key: GOBBLIN-1380
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1380
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
