[
https://issues.apache.org/jira/browse/GOBBLIN-1417?focusedWorklogId=582943&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-582943
]
ASF GitHub Bot logged work on GOBBLIN-1417:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/21 21:49
Start Date: 14/Apr/21 21:49
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3253:
URL: https://github.com/apache/gobblin/pull/3253#discussion_r613609065
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/orc/OrcKeyCompactorOutputFormat.java
##########
@@ -32,14 +31,19 @@
import org.apache.orc.mapreduce.OrcMapreduceRecordWriter;
import org.apache.orc.mapreduce.OrcOutputFormat;
-import static
org.apache.gobblin.compaction.mapreduce.CompactorOutputCommitter.*;
+import lombok.extern.slf4j.Slf4j;
+
+import org.apache.gobblin.compaction.mapreduce.CompactorOutputCommitter;
+import org.apache.gobblin.writer.GobblinOrcWriter;
+
+import static
org.apache.gobblin.compaction.mapreduce.CompactorOutputCommitter.COMPACTION_OUTPUT_EXTENSION;
Review comment:
no, explicit import is obviously better here. thanks for fixing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 582943)
Time Spent: 50m (was: 40m)
> Make row batch size in ORC Mapreduce writer configurable
> --------------------------------------------------------
>
> Key: GOBBLIN-1417
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1417
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-compaction
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Issac Buenrostro
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Current behavior enforces the default row batch size of 1024. To prevent OOMs
> during writes, this config may need to be overridden.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
