[
https://issues.apache.org/jira/browse/GOBBLIN-1417?focusedWorklogId=593082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-593082
]
ASF GitHub Bot logged work on GOBBLIN-1417:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/May/21 00:10
Start Date: 07/May/21 00:10
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on pull request #3253:
URL: https://github.com/apache/gobblin/pull/3253#issuecomment-833960798
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3253?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3253](https://codecov.io/gh/apache/gobblin/pull/3253?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(bf4bd3f) into
[master](https://codecov.io/gh/apache/gobblin/commit/701840858f1323a1f009a44bc70c1e14e7464935?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7018408) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/gobblin/pull/3253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3253 +/- ##
========================================
Coverage 8.99% 9.00%
- Complexity 1740 1743 +3
========================================
Files 2037 2037
Lines 79237 79244 +7
Branches 8838 8838
========================================
+ Hits 7129 7137 +8
Misses 71406 71406
+ Partials 702 701 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...va/org/apache/gobblin/writer/GobblinOrcWriter.java](https://codecov.io/gh/apache/gobblin/pull/3253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tb3JjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Hb2JibGluT3JjV3JpdGVyLmphdmE=)
| `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
|
[...action/mapreduce/CompactionOrcJobConfigurator.java](https://codecov.io/gh/apache/gobblin/pull/3253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL0NvbXBhY3Rpb25PcmNKb2JDb25maWd1cmF0b3IuamF2YQ==)
| `93.75% <100.00%> (+0.89%)` | `9.00 <2.00> (+2.00)` | |
|
[...ion/mapreduce/orc/OrcKeyCompactorOutputFormat.java](https://codecov.io/gh/apache/gobblin/pull/3253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNLZXlDb21wYWN0b3JPdXRwdXRGb3JtYXQuamF2YQ==)
| `100.00% <100.00%> (ø)` | `5.00 <1.00> (+1.00)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/gobblin/pull/3253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `92.85% <0.00%> (+7.14%)` | `3.00% <0.00%> (ø%)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3253?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3253?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[7018408...bf4bd3f](https://codecov.io/gh/apache/gobblin/pull/3253?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 593082)
Time Spent: 1h 20m (was: 1h 10m)
> Make row batch size in ORC Mapreduce writer configurable
> --------------------------------------------------------
>
> Key: GOBBLIN-1417
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1417
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-compaction
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Issac Buenrostro
> Priority: Major
> Fix For: 0.16.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Current behavior enforces the default row batch size of 1024. To prevent OOMs
> during writes, this config may need to be overridden.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
