jack-moseley commented on a change in pull request #3291:
URL: https://github.com/apache/gobblin/pull/3291#discussion_r641073241
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/MultiHopFlowCompiler.java
##########
@@ -201,13 +202,19 @@ public void awaitHealthy() throws InterruptedException {
for (FlowSpec datasetFlowSpec : flowSpecs) {
for (DataNode destNode : destNodes) {
long authStartTime = System.nanoTime();
- boolean authorized =
this.dataMovementAuthorizer.isMovementAuthorized(flowSpec, sourceNode,
destNode);
- Instrumented.updateTimer(dataAuthorizationTimer, System.nanoTime() -
authStartTime, TimeUnit.NANOSECONDS);
- if (!authorized) {
- String message = String.format("Data movement is not authorized
for flow: %s, source: %s, destination: %s",
- flowSpec.getUri().toString(), source, destination);
- log.error(message);
- datasetFlowSpec.getCompilationErrors().add(message);
+ try {
Review comment:
So for the NPE we experienced previously, it happened inside this block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
