arjun4084346 commented on a change in pull request #3291:
URL: https://github.com/apache/gobblin/pull/3291#discussion_r641777757
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -289,10 +288,9 @@ public AddSpecResponse onAddSpec(Spec addedSpec) {
// always try to compile the flow to verify if it is compilable
Dag<JobExecutionPlan> dag =
this.orchestrator.getSpecCompiler().compileFlow(flowSpec);
+ // If dag is null then a compilation error has occurred
Review comment:
Let's updated the javadoc that response is null if compilation fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
