[
https://issues.apache.org/jira/browse/GOBBLIN-1472?focusedWorklogId=611076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611076
]
ASF GitHub Bot logged work on GOBBLIN-1472:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/21 00:23
Start Date: 15/Jun/21 00:23
Worklog Time Spent: 10m
Work Description: autumnust commented on a change in pull request #3311:
URL: https://github.com/apache/gobblin/pull/3311#discussion_r651356303
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionJobConfigurator.java
##########
@@ -249,6 +250,10 @@ protected boolean configureInputAndOutputPaths(Job job,
FileSystemDataset datase
CompactionPathParser.CompactionParserResult rst = parser.parse(dataset);
this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(),
rst.getDstSubDir(), rst.getTimeString());
+ if(this.state.contains(ConfigurationKeys.USE_DATASET_LOCAL_WORK_DIR)) {
+ mrOutputBase = this.state.getProp(MRCompactor.COMPACTION_DEST_DIR);
+ this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(),
ConfigurationKeys.TMP_DIR, rst.getDstSubDir(), rst.getTimeString());
Review comment:
Seems too long a line, did you use the style file in
https://gobblin.readthedocs.io/en/latest/developer-guide/CodingStyle/ ?
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionJobConfigurator.java
##########
@@ -241,6 +241,7 @@ protected void addJars(Configuration conf, State state,
FileSystem fs) throws IO
* a directory containing one or more files.
*
*/
+
Review comment:
Can we remove this blank line ?
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionJobConfigurator.java
##########
@@ -249,6 +250,10 @@ protected boolean configureInputAndOutputPaths(Job job,
FileSystemDataset datase
CompactionPathParser.CompactionParserResult rst = parser.parse(dataset);
this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(),
rst.getDstSubDir(), rst.getTimeString());
Review comment:
Can we rewrite this block as a ternary expression instead of having the
value of `mrOutputPath` to be bind twice if the condition in the line 253 hold?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 611076)
Time Spent: 40m (was: 0.5h)
> Use "gobblin.useDatasetLocalWorkDir" to toggle creation of compaction MR out
> dir
> --------------------------------------------------------------------------------
>
> Key: GOBBLIN-1472
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1472
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
