[ 
https://issues.apache.org/jira/browse/GOBBLIN-1472?focusedWorklogId=611081&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611081
 ]

ASF GitHub Bot logged work on GOBBLIN-1472:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Jun/21 00:40
            Start Date: 15/Jun/21 00:40
    Worklog Time Spent: 10m 
      Work Description: vikrambohra commented on a change in pull request #3311:
URL: https://github.com/apache/gobblin/pull/3311#discussion_r651366359



##########
File path: 
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionJobConfigurator.java
##########
@@ -249,6 +250,10 @@ protected boolean configureInputAndOutputPaths(Job job, 
FileSystemDataset datase
     CompactionPathParser.CompactionParserResult rst = parser.parse(dataset);
     this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(), 
rst.getDstSubDir(), rst.getTimeString());
 
+    if(this.state.contains(ConfigurationKeys.USE_DATASET_LOCAL_WORK_DIR)) {
+      mrOutputBase = this.state.getProp(MRCompactor.COMPACTION_DEST_DIR);
+      this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(), 
ConfigurationKeys.TMP_DIR, rst.getDstSubDir(), rst.getTimeString());

Review comment:
       Yes. I do use the linkedin gobblin code style




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 611081)
    Time Spent: 1h  (was: 50m)

> Use "gobblin.useDatasetLocalWorkDir" to toggle creation of compaction MR out 
> dir
> --------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1472
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1472
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Vikram Bohra
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to