[
https://issues.apache.org/jira/browse/GOBBLIN-1457?focusedWorklogId=622268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622268
]
ASF GitHub Bot logged work on GOBBLIN-1457:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/21 22:19
Start Date: 13/Jul/21 22:19
Worklog Time Spent: 10m
Work Description: jack-moseley commented on a change in pull request
#3299:
URL: https://github.com/apache/gobblin/pull/3299#discussion_r669136411
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-api/src/main/pegasus/org/apache/gobblin/service/Issue.pdl
##########
@@ -0,0 +1,46 @@
+namespace org.apache.gobblin.service
+
+/**
+ * Issue describes a specific unique problem in the job or application.
+ *
+ * Issue can be generated from log entries, health checks, and other places.
+ */
+record Issue {
+
+ /**
+ * Time when the issue have occured
+ */
+ time: Timestamp
Review comment:
Is there a reason to create a new `Timestamp` type here instead of just
directly having the field as a long?
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/troubleshooter/InMemoryMultiContextIssueRepository.java
##########
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.runtime.troubleshooter;
+
+import java.util.Collections;
+import java.util.List;
+
+import org.apache.commons.collections4.map.LRUMap;
+
+import com.typesafe.config.Config;
+import com.typesafe.config.ConfigFactory;
+
+import javax.inject.Inject;
+import javax.inject.Singleton;
+
+import org.apache.gobblin.util.ConfigUtils;
+
+/**
+ * Stores issues from multiple jobs, flows or other contexts in memory.
+ *
+ * To limit the memory consumption, it will keep only the last {@link
#MAX_CONTEXT_COUNT} contexts,
+ * and older ones will be discarded.
+ * */
+@Singleton
+public class InMemoryMultiContextIssueRepository implements
MultiContextIssueRepository {
+ public static final int DEFAULT_MAX_CONTEXT_COUNT = 100;
Review comment:
So just curious, are we planning to use a much larger value than 100?
Because I can imagine if one job of a flow runs, the flow takes several hours
to finish, then a user queries the status, it's possible that 100 other GaaS
jobs have already run in that time and then the issue information will be
missing for the early jobs of the flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 622268)
Time Spent: 2h (was: 1h 50m)
> Automatic troubleshooter
> ------------------------
>
> Key: GOBBLIN-1457
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1457
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Alex Prokofiev
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Automatic troubleshooter will collect issues from job logs and health checks.
> Then it will show users the root cause of the problems with action items on
> how to resolve them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
