[ 
https://issues.apache.org/jira/browse/GOBBLIN-1457?focusedWorklogId=622301&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622301
 ]

ASF GitHub Bot logged work on GOBBLIN-1457:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jul/21 00:03
            Start Date: 14/Jul/21 00:03
    Worklog Time Spent: 10m 
      Work Description: aplex commented on a change in pull request #3299:
URL: https://github.com/apache/gobblin/pull/3299#discussion_r669187949



##########
File path: 
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-api/src/main/pegasus/org/apache/gobblin/service/Issue.pdl
##########
@@ -0,0 +1,46 @@
+namespace org.apache.gobblin.service
+
+/**
+ * Issue describes a specific unique problem in the job or application.
+ *
+ * Issue can be generated from log entries, health checks, and other places.
+ */
+record Issue {
+
+  /**
+   * Time when the issue have occured
+   */
+  time: Timestamp

Review comment:
       It's actually unclear what "long" means for Time. In the most common 
interpretation, unix timestamp is a number of seconds since 1970, but in our 
API it is milliseconds. Having a type reference with a description of what it 
means should be more clear. Timestamp type comment says that it is in 
milliseconds.
   
   Personally, I think we should have used ISO format like 
"2015-04-14T11:07:36.639Z" that is both human- and computer- readable, but it's 
too late to change it since other parts of API use timestamps.  
https://stackoverflow.com/a/29626123 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 622301)
    Time Spent: 2h 20m  (was: 2h 10m)

> Automatic troubleshooter
> ------------------------
>
>                 Key: GOBBLIN-1457
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1457
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-core
>            Reporter: Alex Prokofiev
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> Automatic troubleshooter will collect issues from job logs and health checks. 
> Then it will show users the root cause of the problems with action items on 
> how to resolve them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to