[
https://issues.apache.org/jira/browse/GOBBLIN-1537?focusedWorklogId=647659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647659
]
ASF GitHub Bot logged work on GOBBLIN-1537:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/21 01:19
Start Date: 08/Sep/21 01:19
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3387:
URL: https://github.com/apache/gobblin/pull/3387#discussion_r703954443
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/trash/Trash.java
##########
@@ -94,6 +97,8 @@ public Path getTrashLocation() throws IOException {
*/
protected Path createTrashLocation(FileSystem fs, Properties props, String
user) throws IOException {
Path trashLocation;
+ new DestinationDatasetHandlerService(new State(props), false, null)
Review comment:
Yes, is supposed to add configs to props. I thought about having a
direct method to determine trash location, but we then will need to add a
method in interface DestinationDatasetHandler. Should i do it that way?
Another way is to create a custom trash factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 647659)
Time Spent: 20m (was: 10m)
> use DatasetHandlerService to customize trash location
> -----------------------------------------------------
>
> Key: GOBBLIN-1537
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1537
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
