[
https://issues.apache.org/jira/browse/GOBBLIN-1537?focusedWorklogId=648325&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648325
]
ASF GitHub Bot logged work on GOBBLIN-1537:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/21 02:12
Start Date: 09/Sep/21 02:12
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on a change in pull request
#3387:
URL: https://github.com/apache/gobblin/pull/3387#discussion_r704897462
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/trash/TrashFactory.java
##########
@@ -59,19 +59,12 @@ public static Trash createTrash(FileSystem fs, Properties
props) throws IOExcept
*/
public static Trash createTrash(FileSystem fs, Properties props, String user)
throws IOException {
- if(props.containsKey(TRASH_TEST) &&
Boolean.parseBoolean(props.getProperty(TRASH_TEST))) {
- LOG.info("Creating a test trash. Nothing will actually be deleted.");
- return new TestTrash(fs, props, user);
- }
- if(props.containsKey(SIMULATE) &&
Boolean.parseBoolean(props.getProperty(SIMULATE))) {
- LOG.info("Creating a simulate trash. Nothing will actually be deleted.");
- return new MockTrash(fs, props, user);
- }
- if(props.containsKey(SKIP_TRASH) &&
Boolean.parseBoolean(props.getProperty(SKIP_TRASH))) {
Review comment:
Can you please reframe your question? Why do we no longer handle
SKIP_TRASH and SIMULATE? I moved this piece of code to
createTestMockOrImmediateDeletionTrash()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 648325)
Time Spent: 50m (was: 40m)
> use DatasetHandlerService to customize trash location
> -----------------------------------------------------
>
> Key: GOBBLIN-1537
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1537
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
