[
https://issues.apache.org/jira/browse/GOBBLIN-1544?focusedWorklogId=650668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650668
]
ASF GitHub Bot logged work on GOBBLIN-1544:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/21 16:13
Start Date: 14/Sep/21 16:13
Worklog Time Spent: 10m
Work Description: sv2000 commented on a change in pull request #3396:
URL: https://github.com/apache/gobblin/pull/3396#discussion_r708429476
##########
File path:
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java
##########
@@ -911,6 +909,18 @@ private long computeCompletenessWatermark(String table,
SortedSet<ZonedDateTime>
return completionWatermark;
}
+ /**
+ * if datepartition is greater than previousWatermark
+ * and hour(now) > hour(prevWatermark) + 1
+ * and hour(now) > hour(datepartition)
Review comment:
Can we explain each condition in more human-friendly terms?
##########
File path:
gobblin-iceberg/src/main/java/org/apache/gobblin/iceberg/writer/IcebergMetadataWriter.java
##########
@@ -911,6 +909,18 @@ private long computeCompletenessWatermark(String table,
SortedSet<ZonedDateTime>
return completionWatermark;
}
+ /**
+ * if datepartition is greater than previousWatermark
+ * and hour(now) > hour(prevWatermark) + 1
+ * and hour(now) > hour(datepartition)
+ * check audit counts for completeness
+ */
+ private boolean checkAudit(ZonedDateTime previousWatermark, ZonedDateTime
datepartition, ZonedDateTime now, TimeIterator.Granularity granularity) {
Review comment:
checkAudit -> shouldCheckAudit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 650668)
Time Spent: 40m (was: 0.5h)
> Fix Edge case for streaming completion watermark
> ------------------------------------------------
>
> Key: GOBBLIN-1544
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1544
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
