[
https://issues.apache.org/jira/browse/GOBBLIN-1544?focusedWorklogId=650673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650673
]
ASF GitHub Bot logged work on GOBBLIN-1544:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/21 16:22
Start Date: 14/Sep/21 16:22
Worklog Time Spent: 10m
Work Description: codecov-commenter edited a comment on pull request
#3396:
URL: https://github.com/apache/gobblin/pull/3396#issuecomment-919293867
#
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3396?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#3396](https://codecov.io/gh/apache/gobblin/pull/3396?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(1835518) into
[master](https://codecov.io/gh/apache/gobblin/commit/47707df00a6884ada5974a5f5203408ce1efb890?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(47707df) will **decrease** coverage by `3.20%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/gobblin/pull/3396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #3396 +/- ##
============================================
- Coverage 46.54% 43.33% -3.21%
+ Complexity 10243 2007 -8236
============================================
Files 2062 401 -1661
Lines 80413 17184 -63229
Branches 8981 2115 -6866
============================================
- Hits 37429 7447 -29982
+ Misses 39516 8899 -30617
+ Partials 3468 838 -2630
```
| [Impacted
Files](https://codecov.io/gh/apache/gobblin/pull/3396?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[.../gobblin/iceberg/writer/IcebergMetadataWriter.java](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1pY2ViZXJnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ljZWJlcmcvd3JpdGVyL0ljZWJlcmdNZXRhZGF0YVdyaXRlci5qYXZh)
| `72.11% <50.00%> (-0.09%)` | :arrow_down: |
|
[.../java/org/apache/gobblin/writer/ConsoleWriter.java](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Db25zb2xlV3JpdGVyLmphdmE=)
| | |
|
[...che/gobblin/metrics/event/lineage/LineageInfo.java](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9ldmVudC9saW5lYWdlL0xpbmVhZ2VJbmZvLmphdmE=)
| | |
|
[...java/org/apache/gobblin/metrics/MetricContext.java](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9NZXRyaWNDb250ZXh0LmphdmE=)
| | |
|
[...ache/gobblin/metadata/GlobalMetadataCollector.java](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tbWV0YWRhdGEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YWRhdGEvR2xvYmFsTWV0YWRhdGFDb2xsZWN0b3IuamF2YQ==)
| | |
|
[...conversion/hive/materializer/HiveMaterializer.java](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9tYXRlcmlhbGl6ZXIvSGl2ZU1hdGVyaWFsaXplci5qYXZh)
| | |
|
[...n/source/extractor/extract/sftp/SftpExtractor.java](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9zZnRwL1NmdHBFeHRyYWN0b3IuamF2YQ==)
| | |
|
[...obblin/azkaban/EmbeddedGobblinYarnAppLauncher.java](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0VtYmVkZGVkR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh)
| | |
|
[...main/java/org/apache/gobblin/r2/D2ClientProxy.java](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taHR0cC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9yMi9EMkNsaWVudFByb3h5LmphdmE=)
| | |
|
[...apache/gobblin/publisher/TaskPublisherBuilder.java](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9UYXNrUHVibGlzaGVyQnVpbGRlci5qYXZh)
| | |
| ... and [1652
more](https://codecov.io/gh/apache/gobblin/pull/3396/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/gobblin/pull/3396?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/gobblin/pull/3396?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[47707df...1835518](https://codecov.io/gh/apache/gobblin/pull/3396?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 650673)
Time Spent: 50m (was: 40m)
> Fix Edge case for streaming completion watermark
> ------------------------------------------------
>
> Key: GOBBLIN-1544
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1544
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
